From: Willem Jan Withagen <wjw@digiware.nl>
Date: Mon, 29 May 2017 21:06:46 +0000 (+0200)
Subject: rc/test/osdc/object_cacher_stress.cc: fix comparison
X-Git-Tag: ses5-milestone6~9^2~1^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=90dc421cac5061767c4c5d812ed510cf2df4298e;p=ceph.git

rc/test/osdc/object_cacher_stress.cc: fix comparison

Clang complains:
  /home/jenkins/workspace/ceph-freebsd/src/test/osdc/object_cacher_stress.cc:50:26: error: ordered comparison between pointer and zero ('std::atomic<unsigned int> *' and 'int')
      assert(m_outstanding > 0);
               ~~~~~~~~~~~~~ ^ ~
  /home/jenkins/workspace/ceph-freebsd/src/include/assert.h:117:5: note: expanded from macro 'assert'
    ((expr)                                                               \
        ^~~~
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
---

diff --git a/src/test/osdc/object_cacher_stress.cc b/src/test/osdc/object_cacher_stress.cc
index fc9c56f955548..103347d3ac8a0 100644
--- a/src/test/osdc/object_cacher_stress.cc
+++ b/src/test/osdc/object_cacher_stress.cc
@@ -47,8 +47,8 @@ public:
     : m_op(op), m_outstanding(outstanding) {}
   void finish(int r) override {
     m_op->done++;
-    assert(m_outstanding > 0);
-    *m_outstanding--;
+    assert(*m_outstanding > 0);
+    (*m_outstanding)--;
   }
 };