From: Ronen Friedman <rfriedma@redhat.com>
Date: Sun, 8 Aug 2021 14:33:33 +0000 (+0000)
Subject: common: removing the explicit attribute from a public copy constructor
X-Git-Tag: v17.1.0~1025^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9162613acf10dab64454eb46ffce689ceb916cdf;p=ceph.git

common: removing the explicit attribute from a public copy constructor

A copy constructor marked explicit is almost useless (and
triggers a static-analyzer warning).

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
---

diff --git a/src/common/config_proxy.h b/src/common/config_proxy.h
index e43a7c6dd67c..02c670f60277 100644
--- a/src/common/config_proxy.h
+++ b/src/common/config_proxy.h
@@ -109,7 +109,7 @@ public:
   explicit ConfigProxy(bool is_daemon)
     : config{values, obs_mgr, is_daemon}
   {}
-  explicit ConfigProxy(const ConfigProxy &config_proxy)
+  ConfigProxy(const ConfigProxy &config_proxy)
     : values(config_proxy.get_config_values()),
       config{values, obs_mgr, config_proxy.config.is_daemon}
   {}