From: Darrick J. Wong Date: Mon, 10 Nov 2025 18:26:17 +0000 (-0800) Subject: common: leave any breadcrumbs when _link_out_file_named can't find the output file X-Git-Tag: v2025.11.18~12 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=927e55a2ae5d647f9dc42be84ecf053901693f89;p=xfstests-dev.git common: leave any breadcrumbs when _link_out_file_named can't find the output file _link_out_file_named is an obnoxiously complicated helper involving a perl script embedded inside a bash subshell that does ... a lookup of some sort involving comparing the comma-separated list in its second argument against a comma-separated list in a config file that then maps to an output file suffix. I don't know what it really does. The .cfg file format is undocumented except for the perl script. This is really irritating every time I have to touch any of these tests with flexible golden outputs, and I frequently screw up the mapping. The helper is not very helpful when you do this, because it doesn't even try to tell you *which* suffix it found, let alone how it got there. Fix this up so that the .full file gets some diagnostics, even if the stdout text is "no qualified output". Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Zorro Lang --- diff --git a/common/rc b/common/rc index a10ac177..cb91c00d 100644 --- a/common/rc +++ b/common/rc @@ -3825,6 +3825,7 @@ _link_out_file_named() ' <$seqfull.cfg) rm -f $1 || _fail "_link_out_file_named: failed to remove existing output file" ln -fs $(basename $1).$suffix $1 || _fail "$(basename $1).$suffix: could not setup output file" + test -r $1 || _fail "$(basename $1).$suffix: output file for feature set \"$2\" not found" } _link_out_file()