From: Sage Weil <sage@inktank.com>
Date: Sat, 25 Aug 2012 02:51:30 +0000 (-0700)
Subject: LogEntry: pass by reference
X-Git-Tag: v0.53~229^2~25
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=929892fe567f1defdc76344c8d430dce66d41d8a;p=ceph.git

LogEntry: pass by reference

CID 717030: Big parameter passed by value (PASS_BY_VALUE)
At (1): Passing parameter w of type entity_inst_t (size 152 bytes) by value.

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/src/common/LogEntry.h b/src/common/LogEntry.h
index e8509d5a5b11f..67ac9e638340c 100644
--- a/src/common/LogEntry.h
+++ b/src/common/LogEntry.h
@@ -44,7 +44,7 @@ struct LogEntryKey {
   uint64_t seq;
 
   LogEntryKey() {}
-  LogEntryKey(entity_inst_t w, utime_t t, uint64_t s) : who(w), stamp(t), seq(s) {}
+  LogEntryKey(const entity_inst_t& w, utime_t t, uint64_t s) : who(w), stamp(t), seq(s) {}
 
   void encode(bufferlist& bl) const;
   void decode(bufferlist::iterator& bl);