From: Sage Weil <sage@newdream.net>
Date: Tue, 29 May 2012 23:41:42 +0000 (-0700)
Subject: test_filestore_workloadgen: write zeros, not random bytes
X-Git-Tag: v0.48argonaut~151^2~9
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=92fec423647a6c4b11c7fc45e52e34c484845c6e;p=ceph.git

test_filestore_workloadgen: write zeros, not random bytes

The random byte generation is sufficiently slow that it skews the results.
Zeros are good enough!

Signed-off-by: Sage Weil <sage@newdream.net>
---

diff --git a/src/test/filestore/workload_generator.cc b/src/test/filestore/workload_generator.cc
index dab0b4513fb..8fc9756e7db 100644
--- a/src/test/filestore/workload_generator.cc
+++ b/src/test/filestore/workload_generator.cc
@@ -227,10 +227,14 @@ void WorkloadGenerator::get_filled_byte_array(bufferlist& bl, size_t size)
     "abcdefghijklmnopqrstuvwxyz";
 
   bufferptr bp(size);
-  for (unsigned int i = 0; i < size - 1; i++) {
-    bp[i] = alphanum[rand() % sizeof(alphanum)];
+  if (false) {
+    for (unsigned int i = 0; i < size - 1; i++) {
+      bp[i] = alphanum[rand() % sizeof(alphanum)];
+    }
+    bp[size - 1] = '\0';
+  } else {
+    bp.zero();
   }
-  bp[size - 1] = '\0';
   bl.append(bp);
 }