From: Venky Shankar <vshankar@redhat.com>
Date: Thu, 15 Apr 2021 09:47:23 +0000 (-0400)
Subject: cephfs-mirror: use sensible mount timeout when mounting local/remote fs
X-Git-Tag: v16.2.5~85^2~15
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=93906cfb03654f9f4076f342b5bf38efaa12533b;p=ceph.git

cephfs-mirror: use sensible mount timeout when mounting local/remote fs

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit db4bade78cae576b98a61e1c15e609a650613f2a)

 Conflicts:
	src/common/options/cephfs-mirror.yaml.in

cephfs-mirror.yaml.in does not exist in pacific -- use src/common/options.cc
to detail the configuration.
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 8e3501e6232..a6dfd9b6067 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -9153,6 +9153,12 @@ std::vector<Option> get_cephfs_mirror_options() {
     .set_min(0)
     .set_description("interval to restart failed mirror instances")
     .set_long_description("Interval in seconds to restart failed mirror instances. Setting to zero (0) disables restarting failed mirror instances."),
+
+    Option("cephfs_mirror_mount_timeout", Option::TYPE_SECS, Option::LEVEL_ADVANCED)
+    .set_default(10)
+    .set_min(0)
+    .set_description("timeout for mounting primary/seconday ceph file system")
+    .set_long_description("Timeout in seconds for mounting primary or secondary (remote) ceph file system by the cephfs-mirror daemon. Setting this to a higher value could result in the mirror daemon getting stalled when mounting a file system if the cluster is not reachable. This option is used to override the usual client_mount_timeout."),
     });
 }
 
diff --git a/src/tools/cephfs_mirror/Utils.cc b/src/tools/cephfs_mirror/Utils.cc
index 617ae5ab4a6..733bfc9bf84 100644
--- a/src/tools/cephfs_mirror/Utils.cc
+++ b/src/tools/cephfs_mirror/Utils.cc
@@ -108,6 +108,15 @@ int mount(RadosRef cluster, const Filesystem &filesystem, bool cross_check_fscid
     return r;
   }
 
+  // mount timeout applies for local and remote mounts.
+  auto mount_timeout = g_ceph_context->_conf.get_val<std::chrono::seconds>
+    ("cephfs_mirror_mount_timeout").count();
+  r = ceph_set_mount_timeout(cmi, mount_timeout);
+  if (r < 0) {
+    derr << ": mount error: " << cpp_strerror(r) << dendl;
+    return r;
+  }
+
   r = ceph_init(cmi);
   if (r < 0) {
     derr << ": mount error: " << cpp_strerror(r) << dendl;