From: Loic Dachary <loic@dachary.org>
Date: Fri, 20 Dec 2013 19:39:21 +0000 (+0100)
Subject: mon: unit test for osd pool create
X-Git-Tag: v0.75~48^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=93c44cb144588103ef3dd5b96cee69cd2a47142d;p=ceph.git

mon: unit test for osd pool create

It is inconvenient to run such tests in the
qa/workunits/cephtool/test.sh because they require that the mon is
restarted to test errors in the format of the default erasure code
properties and check the appropriate error message is output.

osd-pool-create.sh runs a single mon from sources using command
line options and a temporary directory, the same way vstart.sh does but
lightweight.

Signed-off-by: Loic Dachary <loic@dachary.org>
---

diff --git a/src/test/Makefile.am b/src/test/Makefile.am
index bda6472a62e..f3a433ab4e9 100644
--- a/src/test/Makefile.am
+++ b/src/test/Makefile.am
@@ -239,6 +239,7 @@ bin_DEBUGPROGRAMS += ceph_bench_log
 check_SCRIPTS += \
 	unittest_bufferlist.sh \
 	test/encoding/check-generated.sh \
+	test/mon/osd-pool-create.sh \
 	test/vstart_wrapped_tests.sh
 
 # target to build but not run the unit tests
diff --git a/src/test/mon/osd-pool-create.sh b/src/test/mon/osd-pool-create.sh
new file mode 100755
index 00000000000..bb2b0a0e7a7
--- /dev/null
+++ b/src/test/mon/osd-pool-create.sh
@@ -0,0 +1,94 @@
+#!/bin/bash
+#
+# Copyright (C) 2013 Cloudwatt <libre.licensing@cloudwatt.com>
+#
+# Author: Loic Dachary <loic@dachary.org>
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU Library Public License as published by
+# the Free Software Foundation; either version 2, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Library Public License for more details.
+#
+set -xe
+PS4='$LINENO: '
+
+DIR=osd-pool-create
+rm -fr $DIR
+trap "kill_mon || true ; rm -fr $DIR" EXIT
+mkdir $DIR
+export CEPH_ARGS="--conf /dev/null --auth-supported=none --mon-host=127.0.0.1" 
+
+function run_mon() {
+    ./ceph-mon --id a \
+        --public-addr=127.0.0.1 --mkfs --keyring /dev/null \
+        --fsid=$(uuidgen) --mon-data=$DIR --run-dir=$DIR
+    touch $DIR/keyring
+
+    ./ceph-mon --id a \
+        --chdir= \
+        --mon-data=$DIR \
+        --log-file=$DIR/log \
+        --mon-cluster-log-file=$DIR/log \
+        --run-dir=$DIR \
+        --pid-file=$DIR/pidfile \
+        "$@"
+}
+
+function kill_mon() {
+    while pkill --pidfile $DIR/pidfile ; do : ; done
+    rm -fr $DIR/store.db
+}
+
+# osd_pool_default_erasure_code_properties is 
+# valid JSON but not of the expected type
+run_mon --osd_pool_default_erasure_code_properties 1 
+./ceph osd pool create poolA 12 12 erasure 2>&1 | grep 'must be a JSON object'
+kill_mon
+
+expected='"foo":"bar"'
+# osd_pool_default_erasure_code_properties is JSON
+run_mon --osd_pool_default_erasure_code_properties "{$expected}"
+./ceph --format json osd dump | grep "$expected" && exit 1
+./ceph osd pool create poolA 12 12 erasure
+./ceph --format json osd dump | grep "$expected"
+kill_mon
+
+# osd_pool_default_erasure_code_properties is plain text
+run_mon --osd_pool_default_erasure_code_properties 'foo=bar'
+./ceph --format json osd dump | grep "$expected" && exit 1
+./ceph osd pool create poolA 12 12 erasure
+./ceph --format json osd dump | grep "$expected"
+kill_mon
+
+run_mon
+
+# creating an erasure code plugin sets defaults properties
+./ceph --format json osd dump > $DIR/osd.json
+grep "erasure-code-plugin" $DIR/osd.json && exit 1
+./ceph osd pool create erasurecodes 12 12 erasure
+./ceph --format json osd dump | tee $DIR/osd.json
+grep "erasure-code-plugin" $DIR/osd.json > /dev/null
+grep "erasure-code-directory" $DIR/osd.json > /dev/null
+
+./ceph osd pool create erasurecodes 12 12 erasure 2>&1 |
+   grep 'already exists'
+./ceph osd pool create erasurecodes 12 12 2>&1 |
+   grep 'cannot change to type replicated'
+./ceph osd pool create replicated 12 12 replicated
+./ceph osd pool create replicated 12 12 replicated 2>&1 |
+   grep 'already exists'
+./ceph osd pool create replicated 12 12 # default is replicated
+./ceph osd pool create replicated 12    # default is replicated, pgp_num = pg_num
+./ceph osd pool create replicated 12 12 erasure 2>&1 |
+   grep 'cannot change to type erasure'
+
+kill_mon
+
+# Local Variables:
+# compile-command: "cd ../.. ; make TESTS=test/mon/osd-pool-create.sh check"
+# End: