From: Sage Weil Date: Tue, 15 Jan 2019 16:24:10 +0000 (-0600) Subject: msg/async/AsyncMessenger: drop single-use _send_to X-Git-Tag: v14.1.0~361^2~5 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9459c6118abe9370955ac362c8565c1b232e4293;p=ceph.git msg/async/AsyncMessenger: drop single-use _send_to Signed-off-by: Sage Weil --- diff --git a/src/msg/async/AsyncMessenger.cc b/src/msg/async/AsyncMessenger.cc index d310e0cd7cca..8d8ed05107c7 100644 --- a/src/msg/async/AsyncMessenger.cc +++ b/src/msg/async/AsyncMessenger.cc @@ -627,8 +627,10 @@ ConnectionRef AsyncMessenger::get_loopback_connection() return local_connection; } -int AsyncMessenger::_send_to(Message *m, int type, const entity_addrvec_t& addrs) +int AsyncMessenger::send_to(Message *m, int type, const entity_addrvec_t& addrs) { + Mutex::Locker l(lock); + FUNCTRACE(cct); ceph_assert(m); diff --git a/src/msg/async/AsyncMessenger.h b/src/msg/async/AsyncMessenger.h index b12dce625fda..2a91e0cf4019 100644 --- a/src/msg/async/AsyncMessenger.h +++ b/src/msg/async/AsyncMessenger.h @@ -137,11 +137,7 @@ public: * @defgroup Messaging * @{ */ - int send_to(Message *m, int type, const entity_addrvec_t& addrs) override { - Mutex::Locker l(lock); - - return _send_to(m, type, addrs); - } + int send_to(Message *m, int type, const entity_addrvec_t& addrs) override; /** @} // Messaging */ @@ -216,7 +212,6 @@ private: void submit_message(Message *m, AsyncConnectionRef con, const entity_addrvec_t& dest_addrs, int dest_type); - int _send_to(Message *m, int type, const entity_addrvec_t& addrs); void _finish_bind(const entity_addrvec_t& bind_addrs, const entity_addrvec_t& listen_addrs);