From: John Mulligan <jmulligan@redhat.com>
Date: Tue, 11 Jul 2023 19:51:19 +0000 (-0400)
Subject: cephadm: add additional test cases for unit file contents
X-Git-Tag: v19.0.0~153^2~10
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=95d0385b06f946ef6c964f85aed3cbfea5ba2948;p=ceph-ci.git

cephadm: add additional test cases for unit file contents

Asserts more about the unit files.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
---

diff --git a/src/cephadm/tests/test_unit_file.py b/src/cephadm/tests/test_unit_file.py
index cf094c97bc2..193baff35a7 100644
--- a/src/cephadm/tests/test_unit_file.py
+++ b/src/cephadm/tests/test_unit_file.py
@@ -16,6 +16,8 @@ from tests.fixtures import (
     with_cephadm_ctx,
 )
 
+from cephadmlib.constants import CGROUPS_SPLIT_PODMAN_VERSION
+
 _cephadm = import_cephadm()
 
 
@@ -31,3 +33,24 @@ def test_podman_engine_does_not_req_docker():
     ctx.container_engine = mock_podman()
     r = _cephadm.get_unit_file(ctx, '9b9d7609-f4d5-4aba-94c8-effa764d96c9')
     assert 'Requires=docker.service' not in r
+
+
+def test_podman_engine_forking_service():
+    # verity that the podman service uses the forking service type
+    # and related parameters
+    ctx = _cephadm.CephadmContext()
+    ctx.container_engine = mock_podman()
+    r = _cephadm.get_unit_file(ctx, '9b9d7609-f4d5-4aba-94c8-effa764d96c9')
+    assert 'Type=forking' in r
+    assert 'PIDFile=' in r
+    assert 'ExecStartPre' in r
+    assert 'ExecStopPost' in r
+
+
+def test_podman_with_split_cgroups_sets_delegate():
+    ctx = _cephadm.CephadmContext()
+    ctx.container_engine = mock_podman()
+    ctx.container_engine.version = CGROUPS_SPLIT_PODMAN_VERSION
+    r = _cephadm.get_unit_file(ctx, '9b9d7609-f4d5-4aba-94c8-effa764d96c9')
+    assert 'Type=forking' in r
+    assert 'Delegate=yes' in r