From: Patrick Donnelly <pdonnell@redhat.com>
Date: Thu, 18 May 2023 13:56:33 +0000 (-0400)
Subject: qa/tasks/vstart_runner: stop overriding _run_python
X-Git-Tag: v19.0.0~760^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=95e61803e0dc7153af21b5b1c1bd25f258a7c71f;p=ceph.git

qa/tasks/vstart_runner: stop overriding _run_python

Now that the teuthology tools can be run in vstart_runner, there's no
reason to override this method.

Importantly, this enables the use of the new stdin-killer tool [1].

[1] https://github.com/ceph/teuthology/pull/1846

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
---

diff --git a/qa/tasks/vstart_runner.py b/qa/tasks/vstart_runner.py
index 182354c0a43d1..5ad608cebcf0e 100644
--- a/qa/tasks/vstart_runner.py
+++ b/qa/tasks/vstart_runner.py
@@ -645,18 +645,6 @@ class LocalCephFSMount():
         path = "{0}/client.{1}.*.asok".format(d, self.client_id)
         return path
 
-    def _run_python(self, pyscript, py_version='python', sudo=False):
-        """
-        Override this to remove the daemon-helper prefix that is used otherwise
-        to make the process killable.
-        """
-        args = []
-        if sudo:
-            args.append('sudo')
-        args += [py_version, '-c', pyscript]
-        return self.client_remote.run(args=args, wait=False,
-                                      stdout=StringIO(), omit_sudo=(not sudo))
-
     def setup_netns(self):
         if opt_use_ns:
             super(type(self), self).setup_netns()