From: Kefu Chai <kchai@redhat.com>
Date: Mon, 22 Feb 2021 03:46:48 +0000 (+0800)
Subject: mgr/mgr_module correct typing of self_test
X-Git-Tag: v17.1.0~2830^2~9
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=962ffe72ac7bd3e131799f045c9dbecd95e0f9f9;p=ceph.git

mgr/mgr_module correct typing of self_test

self_test() is allowed to return str

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/pybind/mgr/mgr_module.py b/src/pybind/mgr/mgr_module.py
index abfcfbd1bfb03..9d11583aa893d 100644
--- a/src/pybind/mgr/mgr_module.py
+++ b/src/pybind/mgr/mgr_module.py
@@ -1496,7 +1496,7 @@ class MgrModule(ceph_module.BaseMgrModule, MgrModuleLoggingMixin):
     def set_localized_store(self, key: str, val: Optional[str]) -> None:
         return self._set_localized(key, val, self.set_store)
 
-    def self_test(self) -> None:
+    def self_test(self) -> Optional[str]:
         """
         Run a self-test on the module. Override this function and implement
         a best as possible self-test for (automated) testing of the module