From: Ramana Raja <rraja@redhat.com>
Date: Fri, 29 Jul 2022 21:51:14 +0000 (-0400)
Subject: mds/Locker: remove session check access when doing cap updates
X-Git-Tag: v19.0.0~433^2~6
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=96305b5eef06e2b379ed95a086edf9e4809a7e70;p=ceph.git

mds/Locker: remove session check access when doing cap updates

as it's too late. Session access authorization already happens
before new caps are issued.

Fixes: https://tracker.ceph.com/issues/56067
Signed-off-by: Ramana Raja <rraja@redhat.com>
---

diff --git a/src/mds/Locker.cc b/src/mds/Locker.cc
index 49e7f947ced2..b4a28fb8379f 100644
--- a/src/mds/Locker.cc
+++ b/src/mds/Locker.cc
@@ -3886,13 +3886,6 @@ bool Locker::_do_cap_update(CInode *in, Capability *cap,
   if (!dirty && !change_max)
     return false;
 
-  Session *session = mds->get_session(m);
-  if (session->check_access(in, MAY_WRITE,
-			    m->caller_uid, m->caller_gid, NULL, 0, 0) < 0) {
-    dout(10) << "check_access failed, dropping cap update on " << *in << dendl;
-    return false;
-  }
-
   // do the update.
   EUpdate *le = new EUpdate(mds->mdlog, "cap update");