From: Raimund Sacherer <rsachere@redhat.com>
Date: Thu, 13 Nov 2025 19:48:13 +0000 (+0100)
Subject: crash: Fix loop when no done file is present
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=980f52e921c34baeb501da4df298cc66f44e6ab6;p=ceph-ci.git

crash: Fix loop when no done file is present

Fix a loop which prevents the crash deamon to process further crashes
when a crash path exists with a meta file, but a missing done file.
Print a log warning.

Fixes: https://tracker.ceph.com/issues/73846
Signed-off-by: Raimund Sacherer <rsachere@redhat.com>
---

diff --git a/src/ceph-crash.in b/src/ceph-crash.in
index 52303c3e8a5..6f57a151093 100755
--- a/src/ceph-crash.in
+++ b/src/ceph-crash.in
@@ -77,7 +77,8 @@ def scrape_path(path):
                 # or the daemon crashed before finishing it
                 time.sleep(1)
                 if not os.path.isfile(donepath):
-                    return
+                    log.warning('no `done` file present. Not processing crash path {}.'.format(crashpath))
+                    continue
             # ok, we can process this one
             rc = post_crash(crashpath)
             if rc == 0: