From: John Mulligan <jmulligan@redhat.com>
Date: Fri, 13 Mar 2026 17:42:09 +0000 (-0400)
Subject: script/build-with-container: add CONFIGURE_ARGS env var to configure step
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9ad0fd3f1a5f3aa9d751abd21bd57b8a5ba93f4a;p=ceph.git

script/build-with-container: add CONFIGURE_ARGS env var to configure step

Add a new optional CONFIGURE_ARGS environment variable to the configure
step so that there's a mechanism to pass custom cmake options that
aren't handled elsewhere in the run-make.sh script.

Because configure is a rather fundamental build step it's probably
preferable to set this via an env file so that it persists across
rebuilds. Using an environment var here also avoids both needing to
change run-make.sh or add another CLI option to BWC which already has
too many.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
---

diff --git a/src/script/build-with-container.py b/src/script/build-with-container.py
index c9fc99fe342..1c23ce71d47 100755
--- a/src/script/build-with-container.py
+++ b/src/script/build-with-container.py
@@ -813,7 +813,11 @@ def get_container(ctx):
 
 @Builder.set(Steps.CONFIGURE)
 def bc_configure(ctx):
-    """Configure the build"""
+    """Configure the build.
+
+    Use the environment variable CONFIGURE_ARGS to pass custom arguments
+    for cmake configuration if needed.
+    """
     ctx.build.wants(Steps.CONTAINER, ctx)
     ctx.build.wants(Steps.NPM_CACHE, ctx)
     cmd = _container_cmd(
@@ -821,7 +825,7 @@ def bc_configure(ctx):
         [
             "bash",
             "-c",
-            f"cd {ctx.cli.homedir} && source ./src/script/run-make.sh && has_build_dir || configure",
+            f"cd {ctx.cli.homedir} && source ./src/script/run-make.sh && has_build_dir || configure ${{CONFIGURE_ARGS}}",
         ],
     )
     with ctx.user_command():