From: Radoslaw Zarzynski <rzarzyns@redhat.com>
Date: Tue, 18 Nov 2025 15:15:34 +0000 (+0000)
Subject: crimson/osd: drop unneccessary variant of PGBackend::getxattr()
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9bdf1fe1bb9911c840f11d0104194b5c0c867989;p=ceph-ci.git

crimson/osd: drop unneccessary variant of PGBackend::getxattr()

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
---

diff --git a/src/crimson/osd/ops_executer.cc b/src/crimson/osd/ops_executer.cc
index 77206b6b061..3b6819278af 100644
--- a/src/crimson/osd/ops_executer.cc
+++ b/src/crimson/osd/ops_executer.cc
@@ -1192,7 +1192,7 @@ static PG::interruptible_future<hobject_t> pgls_filter(
   const PGBackend& backend,
   const hobject_t& sobj)
 {
-  if (const auto xattr = filter.get_xattr(); !xattr.empty()) {
+  if (std::string xattr = filter.get_xattr(); !xattr.empty()) {
     logger().debug("pgls_filter: filter is interested in xattr={} for obj={}",
                    xattr, sobj);
     return backend.getxattr(sobj, std::move(xattr)).safe_then_interruptible(
diff --git a/src/crimson/osd/pg_backend.cc b/src/crimson/osd/pg_backend.cc
index 92611a73fad..faec58fe512 100644
--- a/src/crimson/osd/pg_backend.cc
+++ b/src/crimson/osd/pg_backend.cc
@@ -1153,14 +1153,6 @@ PGBackend::get_attr_ierrorator::future<> PGBackend::getxattr(
   });
 }
 
-PGBackend::get_attr_ierrorator::future<ceph::bufferlist>
-PGBackend::getxattr(
-  const hobject_t& soid,
-  std::string_view key) const
-{
-  return store->get_attr(coll, ghobject_t{soid}, key);
-}
-
 PGBackend::get_attr_ierrorator::future<ceph::bufferlist>
 PGBackend::getxattr(
   const hobject_t& soid,
diff --git a/src/crimson/osd/pg_backend.h b/src/crimson/osd/pg_backend.h
index 1f108ad1b5b..ad7bf32492c 100644
--- a/src/crimson/osd/pg_backend.h
+++ b/src/crimson/osd/pg_backend.h
@@ -281,9 +281,6 @@ public:
     const ObjectState& os,
     OSDOp& osd_op,
     object_stat_sum_t& delta_stats) const;
-  get_attr_ierrorator::future<ceph::bufferlist> getxattr(
-    const hobject_t& soid,
-    std::string_view key) const;
   get_attr_ierrorator::future<ceph::bufferlist> getxattr(
     const hobject_t& soid,
     std::string&& key) const;