From: Avan Thakkar <athakkar@redhat.com>
Date: Tue, 2 Apr 2024 09:45:48 +0000 (+0530)
Subject: mgr/dashboard: fix duplicate grafana panels when on mgr failover
X-Git-Tag: v17.2.8~233^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9c0d022a7121e4e88c153a10568a0c7a1ab386f5;p=ceph.git

mgr/dashboard: fix duplicate grafana panels when on mgr failover

Fixes: https://tracker.ceph.com/issues/64970
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit e6ff23d1297cbcf5da030178c53e14a6b6ce5f43)

Conflicts:
	src/pybind/mgr/cephadm/templates/services/prometheus/prometheus.yml.j2
	src/pybind/mgr/cephadm/tests/test_services.py
---

diff --git a/src/pybind/mgr/cephadm/templates/services/prometheus/prometheus.yml.j2 b/src/pybind/mgr/cephadm/templates/services/prometheus/prometheus.yml.j2
index bb0a8fcae51..a42df93d42c 100644
--- a/src/pybind/mgr/cephadm/templates/services/prometheus/prometheus.yml.j2
+++ b/src/pybind/mgr/cephadm/templates/services/prometheus/prometheus.yml.j2
@@ -14,6 +14,10 @@ alerting:
 scrape_configs:
   - job_name: 'ceph'
     honor_labels: true
+    relabel_configs:
+    - source_labels: [instance]
+      target_label: instance
+      replacement: 'ceph_cluster'
     static_configs:
     - targets:
 {% for mgr in mgr_scrape_list %}
diff --git a/src/pybind/mgr/cephadm/tests/test_services.py b/src/pybind/mgr/cephadm/tests/test_services.py
index 9de22e3bf20..385a8834561 100644
--- a/src/pybind/mgr/cephadm/tests/test_services.py
+++ b/src/pybind/mgr/cephadm/tests/test_services.py
@@ -475,6 +475,10 @@ class TestMonitoring:
                 scrape_configs:
                   - job_name: 'ceph'
                     honor_labels: true
+                    relabel_configs:
+                    - source_labels: [instance]
+                      target_label: instance
+                      replacement: 'ceph_cluster'
                     static_configs:
                     - targets:
                       - '[::1]:9283'