From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Wed, 10 May 2017 18:42:36 +0000 (+0200)
Subject: client/Client.cc: fix USE_AFTER_FREE
X-Git-Tag: v13.0.1~1052^2~8
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9cb79067dc009b488c9dc2d0c4641da88153bfca;p=ceph.git

client/Client.cc: fix USE_AFTER_FREE

Don't call put_request() twice, it's already called by
unregister_request()

Fix for:

CID 1405360 (#1 of 1): Use after free (USE_AFTER_FREE)
 deref_arg: Calling put_request dereferences freed pointer request

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/client/Client.cc b/src/client/Client.cc
index 88b9bf054b5b..bc74fe8f0076 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -1730,7 +1730,6 @@ int Client::make_request(MetaRequest *request,
     r = request->get_abort_code();
     request->item.remove_myself();
     unregister_request(request);
-    put_request(request); // ours
     return r;
   }