From: Sage Weil <sage@redhat.com>
Date: Wed, 26 Aug 2015 19:41:50 +0000 (-0400)
Subject: ceph_test_objectstore: make OMapIterator test work with FileStore
X-Git-Tag: v9.1.0~242^2~4
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9d1582d71fa11de52180d4c9bd8c81b9b6a61a9b;p=ceph.git

ceph_test_objectstore: make OMapIterator test work with FileStore

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/test/objectstore/store_test.cc b/src/test/objectstore/store_test.cc
index 5055959f3917..8e9ca1122260 100644
--- a/src/test/objectstore/store_test.cc
+++ b/src/test/objectstore/store_test.cc
@@ -2051,17 +2051,19 @@ TEST_P(StoreTest, OMapIterator) {
     t.omap_setkeys(cid, hoid, start_set);
     store->apply_transaction(t);
   }
-  ObjectMap::ObjectMapIterator iter = store->get_omap_iterator(cid, hoid);
+  ObjectMap::ObjectMapIterator iter;
   bool correct;
   //basic iteration
   for (int i = 0; i < 100; i++) {
     if (!(i%5)) {
       std::cout << "On iteration " << i << std::endl;
     }
-    ObjectStore::Transaction t;
     bufferlist bl;
-    iter = store->get_omap_iterator(cid, hoid);
 
+    // FileStore may deadlock two active iterators over the same data
+    iter = ObjectMap::ObjectMapIterator();
+
+    iter = store->get_omap_iterator(cid, hoid);
     for (iter->seek_to_first(), count=0; iter->valid(); iter->next(), count++) {
       string key = iter->key();
       bufferlist value = iter->value();
@@ -2077,6 +2079,9 @@ TEST_P(StoreTest, OMapIterator) {
     }
     ASSERT_EQ(attrs.size(), count);
 
+    // FileStore may deadlock an active iterator vs apply_transaction
+    iter = ObjectMap::ObjectMapIterator();
+
     char buf[100];
     snprintf(buf, sizeof(buf), "%d", i);
     bl.clear();
@@ -2085,9 +2090,12 @@ TEST_P(StoreTest, OMapIterator) {
     map<string, bufferlist> to_add;
     to_add.insert(pair<string, bufferlist>("key-" + string(buf), bl));
     attrs.insert(pair<string, bufferlist>("key-" + string(buf), bl));
+    ObjectStore::Transaction t;
     t.omap_setkeys(cid, hoid, to_add);
     store->apply_transaction(t);
   }
+
+  iter = store->get_omap_iterator(cid, hoid);
   //lower bound
   string bound_key = "key-5";
   iter->lower_bound(bound_key);
@@ -2104,6 +2112,8 @@ TEST_P(StoreTest, OMapIterator) {
   }
   ASSERT_EQ(correct, true);
 
+  // FileStore may deadlock an active iterator vs apply_transaction
+  iter = ObjectMap::ObjectMapIterator();
   {
     ObjectStore::Transaction t;
     t.remove(cid, hoid);