From: Neha <nojha@redhat.com>
Date: Thu, 20 Feb 2020 18:04:44 +0000 (+0000)
Subject: common/options.cc: make rocksdb_delete_range_threshold very high
X-Git-Tag: v15.1.1~279^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9d3d8f5170a39e45bc956e2ed85c8ecae48613d6;p=ceph.git

common/options.cc: make rocksdb_delete_range_threshold very high

In b493e96bc181e03d1ab5dfe556a866d6ffb16cec, we added a minimum
key limit before invoking DeleteRange. Existing results show
cpu and latency issues when DeleteRange is invoked for all objects.
Until we have more conclusive results to prove its usefulness, increase
this limit to a very high number to avoid users from hitting it.

Signed-off-by: Neha Ojha <nojha@redhat.com>
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 96f31747f83fe..e11b889cebdcf 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -3648,7 +3648,7 @@ std::vector<Option> get_global_options() {
     .set_description(""),
 
     Option("rocksdb_delete_range_threshold", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
-    .set_default(1024)
+    .set_default(1048576)
     .set_description("The number of keys required to invoke DeleteRange when deleting muliple keys."),
 
     Option("rocksdb_bloom_bits_per_key", Option::TYPE_UINT, Option::LEVEL_ADVANCED)