From: David Zafman <dzafman@redhat.com>
Date: Tue, 10 Feb 2015 01:14:50 +0000 (-0800)
Subject: ceph-objectstore-tool: Eliminate obscure "Invalid params" error
X-Git-Tag: v0.94.7~28^2~11^2~39
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9da6c01b5e59e59a80d00e3d17cf5da05dd84f72;p=ceph.git

ceph-objectstore-tool: Eliminate obscure "Invalid params" error

Will fail later with "No such file or directory" for an empty data-path
because we've already checked for vm.count("data-path")

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit cfca6835bd53d535bde2793551211845b0facebd)
---

diff --git a/src/tools/ceph_objectstore_tool.cc b/src/tools/ceph_objectstore_tool.cc
index e7304ba1ee2c..425044d18519 100644
--- a/src/tools/ceph_objectstore_tool.cc
+++ b/src/tools/ceph_objectstore_tool.cc
@@ -2459,11 +2459,6 @@ int main(int argc, char **argv)
     return 1;
   }
 
-  if (dpath.length() == 0) {
-    cerr << "Invalid params" << std::endl;
-    return 1;
-  }
-
   osflagbits_t flags = 0;
   if (vm.count("skip-journal-replay"))
     flags |= SKIP_JOURNAL_REPLAY;