From: Radoslaw Zarzynski <rzarzyns@redhat.com>
Date: Tue, 22 Jan 2019 20:27:19 +0000 (+0100)
Subject: auth: introduce DummyAuthSessionHandler.
X-Git-Tag: v14.1.1~157^2~62
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=9e5f39d719bac54492fb7555ff06f212e152d801;p=ceph.git

auth: introduce DummyAuthSessionHandler.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
---

diff --git a/src/auth/AuthSessionHandler.h b/src/auth/AuthSessionHandler.h
index 341db88e72153..a2e688ffe8c94 100644
--- a/src/auth/AuthSessionHandler.h
+++ b/src/auth/AuthSessionHandler.h
@@ -41,6 +41,21 @@ struct AuthSessionHandler {
   }
 };
 
+struct DummyAuthSessionHandler : AuthSessionHandler {
+  int sign_message(Message*) final {
+    return 0;
+  }
+  int check_message_signature(Message*) final {
+    return 0;
+  }
+  int encrypt_message(Message*) final {
+    return 0;
+  }
+  int decrypt_message(Message*) final {
+    return 0;
+  }
+};
+
 extern AuthSessionHandler *get_auth_session_handler(
   CephContext *cct, int protocol,
   const CryptoKey& key,
diff --git a/src/auth/krb/KrbSessionHandler.hpp b/src/auth/krb/KrbSessionHandler.hpp
index 9f715730a56d1..ee80d7909333a 100644
--- a/src/auth/krb/KrbSessionHandler.hpp
+++ b/src/auth/krb/KrbSessionHandler.hpp
@@ -29,21 +29,7 @@
  
 #define dout_subsys ceph_subsys_auth
 
-class Message;
-
-class KrbSessionHandler : public AuthSessionHandler {
-
-  public:
-    KrbSessionHandler() = default;
-    ~KrbSessionHandler() override = default; 
-
-    // No security
-    int sign_message(Message* msg) override { return 0; }
-    int check_message_signature(Message* msg) override { return 0; }
-    int encrypt_message(Message* msg) override { return 0; }
-    int decrypt_message(Message* msg) override { return 0; }
-
-  private:
+struct KrbSessionHandler : DummyAuthSessionHandler {
 };
 
 #endif    //-- KRB_SESSION_HANDLER_HPP
diff --git a/src/auth/none/AuthNoneSessionHandler.h b/src/auth/none/AuthNoneSessionHandler.h
index 2c738191f5edb..ca1451f797a8b 100644
--- a/src/auth/none/AuthNoneSessionHandler.h
+++ b/src/auth/none/AuthNoneSessionHandler.h
@@ -13,31 +13,7 @@
  */
 
 #include "auth/AuthSessionHandler.h"
-#include "msg/Message.h"
-
-class AuthNoneSessionHandler : public AuthSessionHandler {
-public:
-  AuthNoneSessionHandler() = default;
-  ~AuthNoneSessionHandler() override = default;
-  
-  // The None suite neither signs nor encrypts messages, so these functions just return success.
-  // Since nothing was signed or encrypted, don't increment the stats.  PLR
-
-  int sign_message(Message *m) override {
-    return 0;
-  }
-
-  int check_message_signature(Message *m) override {
-    return 0;
-  }
-
-  int encrypt_message(Message *m) override {
-    return 0;
-  }
-
-  int decrypt_message(Message *m) override {
-    return 0;
-  }
 
+struct AuthNoneSessionHandler : DummyAuthSessionHandler {
 };
 
diff --git a/src/auth/unknown/AuthUnknownSessionHandler.h b/src/auth/unknown/AuthUnknownSessionHandler.h
index 9bf901004a212..7230663da29b8 100644
--- a/src/auth/unknown/AuthUnknownSessionHandler.h
+++ b/src/auth/unknown/AuthUnknownSessionHandler.h
@@ -13,33 +13,7 @@
  */
 
 #include "auth/AuthSessionHandler.h"
-#include "msg/Message.h"
-
-#define dout_subsys ceph_subsys_auth
-
-class AuthUnknownSessionHandler : public AuthSessionHandler {
-public:
-  AuthUnknownSessionHandler() = default;
-  ~AuthUnknownSessionHandler() override = default;
-  
-  // The Unknown suite neither signs nor encrypts messages, so these functions just return success.
-  // Since nothing was signed or encrypted, don't increment the stats.  PLR
-
-  int sign_message(Message *m) override {
-    return 0;
-  }
-
-  int check_message_signature(Message *m) override {
-    return 0;
-  }
-
-  int encrypt_message(Message *m) override {
-    return 0;
-  }
-
-  int decrypt_message(Message *m) override {
-    return 0;
-  }
 
+struct AuthUnknownSessionHandler : DummyAuthSessionHandler {
 };