From: Mykola Golub <mgolub@suse.com>
Date: Fri, 20 Sep 2019 08:25:01 +0000 (+0100)
Subject: rbd-mirror: potential nullptr dereference in ImageReplayer::handle_start_replay
X-Git-Tag: v15.1.0~1484^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=a01597b00f019a22036a4683074c8a07d1e81d09;p=ceph-ci.git

rbd-mirror: potential nullptr dereference in ImageReplayer::handle_start_replay

Signed-off-by: Mykola Golub <mgolub@suse.com>
---

diff --git a/src/tools/rbd_mirror/ImageReplayer.cc b/src/tools/rbd_mirror/ImageReplayer.cc
index cc419f58da3..96e7e83a59f 100644
--- a/src/tools/rbd_mirror/ImageReplayer.cc
+++ b/src/tools/rbd_mirror/ImageReplayer.cc
@@ -639,7 +639,9 @@ void ImageReplayer<I>::handle_start_replay(int r) {
   reschedule_update_status_task(30);
 
   if (on_replay_interrupted()) {
-    on_finish->complete(r);
+    if (on_finish != nullptr) {
+      on_finish->complete(r);
+    }
     return;
   }