From: Sage Weil <sage@inktank.com>
Date: Sat, 27 Jul 2013 14:48:55 +0000 (-0700)
Subject: ceph_manager: don't mark out an out osd on kill_osd(..., mark_out=True)
X-Git-Tag: 1.1.0~2031
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a039d4ada7a0dc093939f34c501c0014039b74dd;p=teuthology.git

ceph_manager: don't mark out an out osd on kill_osd(..., mark_out=True)

Fixes

2013-07-27T02:02:23.879 INFO:teuthology.task.thrashosds.thrasher:Recovered, killing an osd
2013-07-27T02:02:23.879 INFO:teuthology.task.thrashosds.thrasher:Killing osd 2, live_osds are [3, 4, 0, 1, 5, 2]
2013-07-27T02:02:24.547 INFO:teuthology.task.thrashosds.thrasher:Removing osd 2, in_osds are: [4, 0, 1, 5]
...
ValueError: list.remove(x): x not in list

Signed-off-by: Sage Weil <sage@inktank.com>
---

diff --git a/teuthology/task/ceph_manager.py b/teuthology/task/ceph_manager.py
index e09df0437..ba269bb0e 100644
--- a/teuthology/task/ceph_manager.py
+++ b/teuthology/task/ceph_manager.py
@@ -55,7 +55,7 @@ class Thrasher:
         self.ceph_manager.kill_osd(osd)
         if mark_down:
             self.ceph_manager.mark_down_osd(osd)
-        if mark_out:
+        if mark_out and osd in self.in_osds:
             self.out_osd(osd)
 
     def blackhole_kill_osd(self, osd=None):