From: Patrick Donnelly <pdonnell@ibm.com>
Date: Mon, 18 Nov 2024 16:45:32 +0000 (-0500)
Subject: client: resolve bogus self-assignment
X-Git-Tag: v20.0.0~228^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a07c5ef9259e2cd205a7edef4a1aeefb7afa90f3;p=ceph.git

client: resolve bogus self-assignment

Credit to  Ilya Dryomov for spotting this.

[1] https://github.com/ceph/ceph/pull/60283#discussion_r1846415092

Fixes: 1da6ef237fc70ddd64152d029cd6e0cf8f0c808e
Fixes: https://tracker.ceph.com/issues/68973
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
---

diff --git a/src/client/Client.cc b/src/client/Client.cc
index c404057b929d..fd36566a6e9a 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -5524,7 +5524,7 @@ void Client::handle_cap_export(MetaSession *session, Inode *in, const MConstRef<
 	      ceph_seq_cmp(tcap.seq, m->peer.issue_seq) < 0) {
 	    tcap.cap_id = m->peer.cap_id;
 	    tcap.seq = m->peer.issue_seq - 1;
-	    tcap.issue_seq = tcap.issue_seq;
+	    tcap.issue_seq = m->peer.issue_seq - 1;
 	    tcap.issued |= cap.issued;
 	    tcap.implemented |= cap.issued;
 	    if (&cap == in->auth_cap)