From: Michael Fritch Date: Tue, 3 Mar 2020 15:22:48 +0000 (-0700) Subject: mgr/volumes: remove unneeded assignment to `NoneType` X-Git-Tag: v15.1.1~93^2~1 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=a09af07cb69fbca68f08b5740036cf52aa6f3c27;p=ceph.git mgr/volumes: remove unneeded assignment to `NoneType` fixes mypy error: volumes/fs/operations/versions/__init__.py: note: In member "get_subvolume_object" of class "SubvolumeLoader": volumes/fs/operations/versions/__init__.py:70: error: Incompatible types in assignment (expression has type "None", variable has type "SubvolumeBase") Fixes: https://tracker.ceph.com/issues/44393 Signed-off-by: Michael Fritch --- diff --git a/src/pybind/mgr/volumes/fs/operations/versions/__init__.py b/src/pybind/mgr/volumes/fs/operations/versions/__init__.py index 25dd2d91a921a..f79631b04990b 100644 --- a/src/pybind/mgr/volumes/fs/operations/versions/__init__.py +++ b/src/pybind/mgr/volumes/fs/operations/versions/__init__.py @@ -67,7 +67,6 @@ class SubvolumeLoader(object): except MetadataMgrException as me: if me.errno == -errno.ENOENT and upgrade: self.upgrade_legacy_subvolume(fs, subvolume) - subvolume = None return self.get_subvolume_object(fs, vol_spec, group, subvolname, upgrade=False) else: # log the actual error and generalize error string returned to user