From: Nathan Cutler Date: Wed, 20 Nov 2019 08:15:33 +0000 (+0100) Subject: backport-create-issue: resolve parent only if parent has backport issues X-Git-Tag: v15.1.0~515^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a247904df5e7f4482e15c301c2793748d1afe4ae;p=ceph.git backport-create-issue: resolve parent only if parent has backport issues This fixes an edge case. If a parent issue is in "Pending Backport" status but without any backport issues, the script (when running with --resolve-parent) was wrongly changing the status to "Resolved". Signed-off-by: Nathan Cutler --- diff --git a/src/script/backport-create-issue b/src/script/backport-create-issue index 02a475e5782..a599bd305f7 100755 --- a/src/script/backport-create-issue +++ b/src/script/backport-create-issue @@ -246,6 +246,8 @@ def maybe_resolve(issue, backports, dry_run): global delay_seconds global redmine global status2status_id + if not backports: + return None pending_backport_status_id = status2status_id["Pending Backport"] resolved_status_id = status2status_id["Resolved"] rejected_status_id = status2status_id["Rejected"]