From: Jianpeng Ma Date: Thu, 9 Jan 2020 04:58:22 +0000 (+0800) Subject: os/bluestore/BlueFS: replace flush_log with sync_metadata. X-Git-Tag: v14.2.10~100^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a262328a577acd7dea7195908715dac6510fa070;p=ceph.git os/bluestore/BlueFS: replace flush_log with sync_metadata. Signed-off-by: Jianpeng Ma (cherry picked from commit cdd0e87a73637c25e042caa4bd67497dc72c0386) --- diff --git a/src/os/bluestore/BlueFS.cc b/src/os/bluestore/BlueFS.cc index f66dc5b58547..b68571e40391 100644 --- a/src/os/bluestore/BlueFS.cc +++ b/src/os/bluestore/BlueFS.cc @@ -2131,12 +2131,6 @@ void BlueFS::_pad_bl(bufferlist& bl) } } -void BlueFS::flush_log() -{ - std::unique_lock l(lock); - flush_bdev(); - _flush_and_sync_log(l); -} int BlueFS::_flush_and_sync_log(std::unique_lock& l, uint64_t want_seq, diff --git a/src/os/bluestore/BlueFS.h b/src/os/bluestore/BlueFS.h index cc97db73aec1..f719b3137e37 100644 --- a/src/os/bluestore/BlueFS.h +++ b/src/os/bluestore/BlueFS.h @@ -508,7 +508,6 @@ public: int lock_file(const string& dirname, const string& filename, FileLock **p); int unlock_file(FileLock *l); - void flush_log(); void compact_log(); /// sync any uncommitted state to disk diff --git a/src/test/objectstore/test_bluefs.cc b/src/test/objectstore/test_bluefs.cc index 60e51a12d228..9de5e8d8bdab 100644 --- a/src/test/objectstore/test_bluefs.cc +++ b/src/test/objectstore/test_bluefs.cc @@ -439,10 +439,10 @@ TEST(BlueFS, test_simple_compaction_sync) { string file = "file."; file.append(to_string(j)); fs.unlink(dir, file); - fs.flush_log(); + fs.sync_metadata(); } ASSERT_EQ(0, fs.rmdir(dir)); - fs.flush_log(); + fs.sync_metadata(); } } fs.compact_log(); @@ -492,10 +492,10 @@ TEST(BlueFS, test_simple_compaction_async) { string file = "file."; file.append(to_string(j)); fs.unlink(dir, file); - fs.flush_log(); + fs.sync_metadata(); } ASSERT_EQ(0, fs.rmdir(dir)); - fs.flush_log(); + fs.sync_metadata(); } } fs.compact_log();