From: Samuel Just Date: Thu, 4 Jul 2024 03:49:24 +0000 (-0700) Subject: crimson/.../pg_interval_interrupt_condition: remove IOInterruptCondition(Ref... X-Git-Tag: v19.2.1~307^2~1 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a343d6d69b73f12ac5df7566d7d3e35bdcbb104a;p=ceph.git crimson/.../pg_interval_interrupt_condition: remove IOInterruptCondition(Ref& pg); constructor This variant is error prone, better to be explicit. Signed-off-by: Samuel Just (cherry picked from commit 252801a02807313dcab9a510183dcc1ab5ccc61a) --- diff --git a/src/crimson/osd/pg_interval_interrupt_condition.cc b/src/crimson/osd/pg_interval_interrupt_condition.cc index 62a0988aa8c0..bc54b0914943 100644 --- a/src/crimson/osd/pg_interval_interrupt_condition.cc +++ b/src/crimson/osd/pg_interval_interrupt_condition.cc @@ -17,8 +17,6 @@ namespace crimson::osd { IOInterruptCondition::IOInterruptCondition(Ref& pg, epoch_t e) : pg(pg), e(e) {} -IOInterruptCondition::IOInterruptCondition(Ref& pg) - : pg(pg), e(pg->get_osdmap_epoch()) {} IOInterruptCondition::~IOInterruptCondition() { // for the sake of forward declaring PG (which is a detivate of diff --git a/src/crimson/osd/pg_interval_interrupt_condition.h b/src/crimson/osd/pg_interval_interrupt_condition.h index 4ffb04740c65..95b3595cdd0b 100644 --- a/src/crimson/osd/pg_interval_interrupt_condition.h +++ b/src/crimson/osd/pg_interval_interrupt_condition.h @@ -15,7 +15,6 @@ class PG; class IOInterruptCondition { public: IOInterruptCondition(Ref& pg, epoch_t e); - IOInterruptCondition(Ref& pg); ~IOInterruptCondition(); bool new_interval_created();