From: Sage Weil <sage@redhat.com>
Date: Fri, 27 Mar 2015 16:34:44 +0000 (-0700)
Subject: osd: log a scrub error when we can't pick an auth object
X-Git-Tag: v9.0.2~189^2~3
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a476d8f3903ca78b5cf36d63059f13cb5268efe5;p=ceph.git

osd: log a scrub error when we can't pick an auth object

If we really can't find a suitable auth, log an error.

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/osd/PGBackend.cc b/src/osd/PGBackend.cc
index fe3a80dceb92..0ba4c24c0856 100644
--- a/src/osd/PGBackend.cc
+++ b/src/osd/PGBackend.cc
@@ -571,14 +571,10 @@ void PGBackend::be_compare_scrubmaps(
       be_select_auth_object(*k, maps, okseed, &auth_oi);
     list<pg_shard_t> auth_list;
     if (auth == maps.end()) {
-      // Something is better than nothing
-      // TODO: something is NOT better than nothing, do something like
-      // unfound_lost if no valid copies can be found, or just mark unfound
-      auth = maps.begin();
-      dout(10) << __func__ << ": selecting osd " << auth->first
-	       << " for obj " << *k
-	       << ", something is better than nothing, FIXME"
-	       << dendl;
+      dout(10) << __func__ << ": unable to find any auth object" << dendl;
+      ++shallow_errors;
+      errorstream << __func__ << ": " << pgid << " shard " << j->first
+		  << ": soid failed to pick suitable auth object";
       continue;
     }
     auth_list.push_back(auth->first);