From: Zack Cerza <zack@redhat.com>
Date: Tue, 5 Dec 2017 17:57:43 +0000 (-0700)
Subject: PhysicalConsole: Correctly report power_on failure
X-Git-Tag: 1.1.0~372^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a47be44f8c8a759abae87fa2a27490d3841cd140;p=teuthology.git

PhysicalConsole: Correctly report power_on failure

We've been logging an error, then unconditionally reporting success. Fix
it.

Signed-off-by: Zack Cerza <zack@redhat.com>
---

diff --git a/teuthology/orchestra/console.py b/teuthology/orchestra/console.py
index c15e02b0f..f21110774 100644
--- a/teuthology/orchestra/console.py
+++ b/teuthology/orchestra/console.py
@@ -228,9 +228,10 @@ class PhysicalConsole():
                              timeout=self.timeout)
             if r == 0:
                 break
-        if not self.check_power('on'):
+        if self.check_power('on'):
+            log.info('Power on for {s} completed'.format(s=self.shortname))
+        else:
             log.error('Failed to power on {s}'.format(s=self.shortname))
-        log.info('Power on for {s} completed'.format(s=self.shortname))
 
     def power_off(self):
         """