From: Kefu Chai <k.chai@proxmox.com>
Date: Sun, 29 Mar 2026 11:41:24 +0000 (+0800)
Subject: crimson/osd: fix inaccurate comment about child early-exit in get_early_config
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a519613c404cf54cddb86c4f366ef22dc7bcae87;p=ceph.git

crimson/osd: fix inaccurate comment about child early-exit in get_early_config

The comment contained a typo ("taged") and vaguely referred to "one of
the parameters" without explaining what actually happens: the child
calls exit(0) for early-exit paths such as --help and --version, and
the parent detects this by checking for a clean exit with no pipe data.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---

diff --git a/src/crimson/osd/main_config_bootstrap_helpers.cc b/src/crimson/osd/main_config_bootstrap_helpers.cc
index 3454b5dbc394..aafd52964a11 100644
--- a/src/crimson/osd/main_config_bootstrap_helpers.cc
+++ b/src/crimson/osd/main_config_bootstrap_helpers.cc
@@ -337,8 +337,7 @@ get_early_config(int argc, const char *argv[])
     int status;
     waitpid(worker, &status, 0);
 
-    // One of the parameters was taged as exit(0) in the child process
-    // so we need to check if we should exit here
+    // child exited via exit(0) for early-exit paths (e.g. --help, --version)
     if (!have_data && WIFEXITED(status) && WEXITSTATUS(status) == 0) {
       exit(0);
     }