From: Dhairya Parmar <dparmar@redhat.com>
Date: Thu, 7 Dec 2023 17:44:01 +0000 (+0530)
Subject: client: do not accept zero byte write request
X-Git-Tag: v19.3.0~24^2~2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a67d081148ba0680539fbf76ae13c6484bb730de;p=ceph.git

client: do not accept zero byte write request

Fixes: https://tracker.ceph.com/issues/63734
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
---

diff --git a/src/client/Client.cc b/src/client/Client.cc
index d8b6c32090e4..58a289d1a23a 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -11441,6 +11441,10 @@ int64_t Client::_write(Fh *f, int64_t offset, uint64_t size, const char *buf,
   CWF_iofinish *cwf_iofinish = NULL;
   C_SaferCond *cond_iofinish = NULL;
 
+  if (size < 1) { // zero bytes write is not supported by osd
+    return -CEPHFS_EINVAL;
+  }
+
   if ( (uint64_t)(offset+size) > mdsmap->get_max_filesize() && //exceeds config
        (uint64_t)(offset+size) > in->size ) { //exceeds filesize 
       return -CEPHFS_EFBIG;