From: John Mulligan Date: Thu, 25 May 2023 23:17:02 +0000 (-0400) Subject: mgr/orchestrator: reformat ceph.deployment.service_spec import line X-Git-Tag: v18.2.1~326^2~43 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=a787ebf4e965aeb278027f560ebc5b748b7c9877;p=ceph-ci.git mgr/orchestrator: reformat ceph.deployment.service_spec import line Quoting https://peps.python.org/pep-0008/#maximum-line-length ``` The preferred way of wrapping long lines is by using Python’s implied line continuation inside parentheses, brackets and braces. Long lines can be broken over multiple lines by wrapping expressions in parentheses. These should be used in preference to using a backslash for line continuation. ``` I also think it is much more readable and is similar to the style applied by automated code formatting tools like `black`. Signed-off-by: John Mulligan (cherry picked from commit 5cc6f0a147247799478556e01b397f3ee6599f2e) --- diff --git a/src/pybind/mgr/orchestrator/_interface.py b/src/pybind/mgr/orchestrator/_interface.py index 62123c3ea56..2c6458e81fd 100644 --- a/src/pybind/mgr/orchestrator/_interface.py +++ b/src/pybind/mgr/orchestrator/_interface.py @@ -30,8 +30,16 @@ except ImportError: import yaml from ceph.deployment import inventory -from ceph.deployment.service_spec import ServiceSpec, NFSServiceSpec, RGWSpec, \ - IscsiServiceSpec, IngressSpec, SNMPGatewaySpec, MDSSpec, TunedProfileSpec +from ceph.deployment.service_spec import ( + IngressSpec, + IscsiServiceSpec, + MDSSpec, + NFSServiceSpec, + RGWSpec, + SNMPGatewaySpec, + ServiceSpec, + TunedProfileSpec, +) from ceph.deployment.drive_group import DriveGroupSpec from ceph.deployment.hostspec import HostSpec, SpecValidationError from ceph.utils import datetime_to_str, str_to_datetime