From: Sage Weil <sage@redhat.com>
Date: Mon, 29 Jan 2018 14:55:38 +0000 (-0600)
Subject: os/bluestore: disable on_applied sync_complete
X-Git-Tag: v13.0.2~364^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a78cdceeec739bdfbcb19bd0f4f892b564013ea4;p=ceph.git

os/bluestore: disable on_applied sync_complete

1. This is causing problems in ECBackend that are not obvious.
2. It didn't show any performance win anyway.
3. I'm trying to remove on_applied callbacks entirely.  If that works out
this will all be moot!

Fixes: http://tracker.ceph.com/issues/22668
Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc
index 70460aa99e7c..2de8cda682c3 100644
--- a/src/os/bluestore/BlueStore.cc
+++ b/src/os/bluestore/BlueStore.cc
@@ -9205,11 +9205,7 @@ int BlueStore::queue_transactions(
     c->complete(0);
   }
   for (auto c : on_applied) {
-    // NOTE: these may complete out of order since some may be sync and some
-    // may be async.
-    if (!c->sync_complete(0)) {
-      finishers[osr->shard]->queue(c);
-    }
+    finishers[osr->shard]->queue(c);
   }
 
   logger->tinc(l_bluestore_submit_lat, ceph_clock_now() - start);