From: Kefu Chai <kchai@redhat.com>
Date: Mon, 14 Dec 2020 15:14:11 +0000 (+0800)
Subject: crimson/osd: use range-based for loop
X-Git-Tag: v17.0.0~295^2~6
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=a8b518917759ee2e031408e485d0161499208f03;p=ceph-ci.git

crimson/osd: use range-based for loop

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/crimson/osd/replicated_recovery_backend.cc b/src/crimson/osd/replicated_recovery_backend.cc
index 9c46d9391a2..ded157df7ef 100644
--- a/src/crimson/osd/replicated_recovery_backend.cc
+++ b/src/crimson/osd/replicated_recovery_backend.cc
@@ -558,13 +558,9 @@ ReplicatedRecoveryBackend::get_shards_to_push(const hobject_t& soid)
 {
   std::list<std::map<pg_shard_t, pg_missing_t>::const_iterator> shards;
   assert(pg.get_acting_recovery_backfill().size() > 0);
-  for (set<pg_shard_t>::iterator i =
-      pg.get_acting_recovery_backfill().begin();
-      i != pg.get_acting_recovery_backfill().end();
-      ++i) {
-    if (*i == pg.get_pg_whoami())
+  for (const auto& peer : pg.get_acting_recovery_backfill()) {
+    if (peer == pg.get_pg_whoami())
       continue;
-    pg_shard_t peer = *i;
     map<pg_shard_t, pg_missing_t>::const_iterator j =
       pg.get_shard_missing().find(peer);
     assert(j != pg.get_shard_missing().end());