From: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Date: Tue, 5 Nov 2013 18:40:47 +0000 (+0100)
Subject: os/ObjectStore.cc: prefer prefix ++operator for non-primitive types
X-Git-Tag: v0.74~90^2~1^2~12
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a8e10d3d0a27436c6f1df2601678a8abcc4b79f5;p=ceph.git

os/ObjectStore.cc: prefer prefix ++operator for non-primitive types

Prefer prefix ++operator for non-primitive types like iterators for
performance reasons. Prefix ++/-- operators avoid creating a temporary
copy.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
---

diff --git a/src/os/ObjectStore.cc b/src/os/ObjectStore.cc
index 1a1bbcb0b67d..327c64167d5c 100644
--- a/src/os/ObjectStore.cc
+++ b/src/os/ObjectStore.cc
@@ -504,7 +504,7 @@ int ObjectStore::collection_list(coll_t c, vector<hobject_t>& o)
   int ret = collection_list(c, go);
   if (ret == 0) {
     o.reserve(go.size());
-    for (vector<ghobject_t>::iterator i = go.begin(); i != go.end() ; i++)
+    for (vector<ghobject_t>::iterator i = go.begin(); i != go.end() ; ++i)
       o.push_back(i->hobj);
   }
   return ret;
@@ -520,7 +520,7 @@ int ObjectStore::collection_list_partial(coll_t c, hobject_t start,
   if (ret == 0) {
     *next = gnext.hobj;
     ls->reserve(go.size());
-    for (vector<ghobject_t>::iterator i = go.begin(); i != go.end() ; i++)
+    for (vector<ghobject_t>::iterator i = go.begin(); i != go.end() ; ++i)
       ls->push_back(i->hobj);
   }
   return ret;
@@ -534,7 +534,7 @@ int ObjectStore::collection_list_range(coll_t c, hobject_t start, hobject_t end,
   int ret = collection_list_range(c, gstart, gend, seq, &go);
   if (ret == 0) {
     ls->reserve(go.size());
-    for (vector<ghobject_t>::iterator i = go.begin(); i != go.end() ; i++)
+    for (vector<ghobject_t>::iterator i = go.begin(); i != go.end() ; ++i)
       ls->push_back(i->hobj);
   }
   return ret;