From: Jos Collin <jcollin@redhat.com>
Date: Fri, 18 Aug 2017 01:30:31 +0000 (+0530)
Subject: msg: drop unnecessary polling_stop()
X-Git-Tag: v13.0.0~38^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a96cb5b4da5060819df67c3dd28fa2a82cfbfc59;p=ceph.git

msg: drop unnecessary polling_stop()

Drop the unnecessary polling_stop() in the ~RDMAStack(). The RDMADispatcher object contained in
RDMAStack will get distroyed when RDMAStack gets distroyed. Thus ~RDMADispatcher() will be
called automatically and executes the polling_stop().

Fixes:
The below coverity scan reports.
1. CID 1416590:  Memory - corruptions
2. CID 1416593:  Memory - illegal accesses
3. CID 1416595:  Memory - corruptions
4. CID 1416597:  Memory - illegal accesses

Signed-off-by: Jos Collin <jcollin@redhat.com>
---

diff --git a/src/msg/async/rdma/RDMAStack.cc b/src/msg/async/rdma/RDMAStack.cc
index 7e5c9d3e9bf3..b3fefcda1afe 100644
--- a/src/msg/async/rdma/RDMAStack.cc
+++ b/src/msg/async/rdma/RDMAStack.cc
@@ -547,8 +547,6 @@ RDMAStack::~RDMAStack()
   if (cct->_conf->ms_async_rdma_enable_hugepage) {
     unsetenv("RDMAV_HUGEPAGES_SAFE");	//remove env variable on destruction
   }
-
-  dispatcher.polling_stop();
 }
 
 void RDMAStack::spawn_worker(unsigned i, std::function<void ()> &&func)