From: Kefu Chai <kchai@redhat.com>
Date: Mon, 1 Apr 2019 03:49:57 +0000 (+0800)
Subject: osdc/Objecter: use list::push_back(T&&) for less memcpy
X-Git-Tag: v15.1.0~2989^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a9b7822d1bd7d593787a29c598850632002ae0e8;p=ceph.git

osdc/Objecter: use list::push_back(T&&) for less memcpy

also use range-based loop for better readablity.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/osdc/Objecter.h b/src/osdc/Objecter.h
index 702743f567aa..81437faae687 100644
--- a/src/osdc/Objecter.h
+++ b/src/osdc/Objecter.h
@@ -534,15 +534,15 @@ struct ObjectOperation {
 	  obj_list_watch_response_t resp;
 	  decode(resp, p);
 	  if (pwatchers) {
-	    for (auto i = resp.entries.begin(); i != resp.entries.end(); ++i) {
+	    for (const auto& watch_item : resp.entries) {
 	      obj_watch_t ow;
-	      std::string sa = i->addr.get_legacy_str();
+	      std::string sa = watch_item.addr.get_legacy_str();
 	      strncpy(ow.addr, sa.c_str(), sizeof(ow.addr) - 1);
 	      ow.addr[sizeof(ow.addr) - 1] = '\0';
-	      ow.watcher_id = i->name.num();
-	      ow.cookie = i->cookie;
-	      ow.timeout_seconds = i->timeout_seconds;
-	      pwatchers->push_back(ow);
+	      ow.watcher_id = watch_item.name.num();
+	      ow.cookie = watch_item.cookie;
+	      ow.timeout_seconds = watch_item.timeout_seconds;
+	      pwatchers->push_back(std::move(ow));
 	    }
 	  }
 	}