From: Matan Breizman <mbreizma@redhat.com>
Date: Mon, 30 Mar 2026 14:23:46 +0000 (+0300)
Subject: crimson/os/seastore/transaction: rename need_wait_rewrite
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=a9c0419613d0eb923006af1b389675c529d13ba2;p=ceph.git

crimson/os/seastore/transaction: rename need_wait_rewrite

We will need this gate for other types of txns as well

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---

diff --git a/src/crimson/os/seastore/cached_extent.cc b/src/crimson/os/seastore/cached_extent.cc
index cb65589a28e2..1aae9c43ed4d 100644
--- a/src/crimson/os/seastore/cached_extent.cc
+++ b/src/crimson/os/seastore/cached_extent.cc
@@ -506,7 +506,7 @@ void ExtentCommitter::block_trans(Transaction &t) {
   for (auto &item : prior.read_transactions) {
     TRACET("blocking trans {} for rewriting {}",
       t, item.t->get_trans_id(), *item.ref);
-    item.t->need_wait_rewrite = true;
+    item.t->need_wait_visibility = true;
   }
 }
 
@@ -516,7 +516,7 @@ void ExtentCommitter::unblock_trans(Transaction &t) {
   for (auto &item : prior.read_transactions) {
     TRACET("unblocking trans {} for rewriting {}",
       t, item.t->get_trans_id(), *item.ref);
-    item.t->need_wait_rewrite = false;
+    item.t->need_wait_visibility = false;
   }
 }
 
diff --git a/src/crimson/os/seastore/transaction.h b/src/crimson/os/seastore/transaction.h
index 1b118457cee3..7b0a4433c513 100644
--- a/src/crimson/os/seastore/transaction.h
+++ b/src/crimson/os/seastore/transaction.h
@@ -572,7 +572,7 @@ public:
     ool_write_stats = {};
     rewrite_stats = {};
     conflicted = false;
-    need_wait_rewrite = false;
+    need_wait_visibility = false;
     assert(backref_entries.empty());
     if (!has_reset) {
       has_reset = true;
@@ -690,7 +690,8 @@ public:
   }
 
   btree_cursor_stats_t cursor_stats;
-  bool need_wait_rewrite = false;
+
+ bool need_wait_visibility = false;
 
 private:
   friend class Cache;
diff --git a/src/crimson/os/seastore/transaction_manager.cc b/src/crimson/os/seastore/transaction_manager.cc
index ddf4051e7fad..de8b62cb3c49 100644
--- a/src/crimson/os/seastore/transaction_manager.cc
+++ b/src/crimson/os/seastore/transaction_manager.cc
@@ -544,7 +544,7 @@ TransactionManager::do_submit_transaction(
     tref.get_handle().enter(write_pipeline.prepare)
   );
 
-  while (tref.need_wait_rewrite) {
+  while (tref.need_wait_visibility) {
     co_await trans_intr::make_interruptible(seastar::yield());
   }
   if (trim_alloc_to && *trim_alloc_to != JOURNAL_SEQ_NULL) {