From: Vallari Agrawal <val.agl002@gmail.com>
Date: Wed, 12 Jun 2024 17:13:30 +0000 (+0530)
Subject: teuthology/kill.py: Fix "TypeError: 'NoneType' object is not iterable"
X-Git-Tag: 1.2.0~23^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=aa0a5d28e7aca83c8dd9b4e7c63ec0111b541883;p=teuthology.git

teuthology/kill.py: Fix "TypeError: 'NoneType' object is not iterable"

Fixes: https://tracker.ceph.com/issues/66440#note-1

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
---

diff --git a/teuthology/kill.py b/teuthology/kill.py
index c55880bc3..8a629f1cd 100755
--- a/teuthology/kill.py
+++ b/teuthology/kill.py
@@ -233,11 +233,11 @@ def find_pids(run_name):
 def find_targets(run_name: str, job_id: Union[str, int, None] = None) -> dict:
     if job_id is not None:
         job_info = report.ResultsReporter().get_jobs(run_name, str(job_id))
-        return job_info.get("targets", dict())
+        return job_info.get("targets") or dict()
     result = dict()
     run_info = report.ResultsReporter().get_jobs(run_name)
     for job_info in run_info:
         if job_info.get("status") not in ("running", "waiting"):
             continue
-        result.update(job_info.get("targets", dict()))
+        result.update(job_info.get("targets") or dict())
     return result