From: Kefu Chai Date: Mon, 27 May 2019 11:55:59 +0000 (+0800) Subject: common: no need to include ceph_assert.h X-Git-Tag: v15.1.0~2614^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=aa2047ec21cbcb26411f88fb02ebee35a5ce49e2;p=ceph.git common: no need to include ceph_assert.h src/common/convenience.h is a header-only library, and it does not use dout or ceph_assert() utilities. so there is no need to include `ceph_assert.h`. Signed-off-by: Kefu Chai --- diff --git a/src/common/convenience.h b/src/common/convenience.h index ad01d48ba7d1..db803c59d5a7 100644 --- a/src/common/convenience.h +++ b/src/common/convenience.h @@ -21,10 +21,6 @@ #include -#include "include/ceph_assert.h" // I despise you. Not you the reader, I'm talking - // to the include file. - - #ifndef CEPH_COMMON_CONVENIENCE_H #define CEPH_COMMON_CONVENIENCE_H diff --git a/src/test/common/CMakeLists.txt b/src/test/common/CMakeLists.txt index f64960a05322..c9c9177fa762 100644 --- a/src/test/common/CMakeLists.txt +++ b/src/test/common/CMakeLists.txt @@ -296,7 +296,6 @@ target_link_libraries(unittest_iso_8601 ceph-common) add_ceph_unittest(unittest_iso_8601) add_executable(unittest_convenience test_convenience.cc) -target_link_libraries(unittest_convenience ceph-common) add_ceph_unittest(unittest_convenience) add_executable(unittest_bounded_key_counter