From: Kefu Chai <kchai@redhat.com>
Date: Sun, 8 Aug 2021 13:41:34 +0000 (+0800)
Subject: test/crimson: drop copy assignment operator
X-Git-Tag: v17.1.0~1168^2~2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=aa62b71bb35c6dfddf79ae63acf7644df1d98a72;p=ceph.git

test/crimson: drop copy assignment operator

because of the const reference member variable of `parent`:

const delta_overlay_t &parent;

we are not allowed to mutate it. so the explicitly defaulted copy assignment
operator is implicitly deleted

this change silences the warnings from Clang like:

 ../src/test/crimson/seastore/test_transaction_manager.cc:159:12: warning: explicitly defaulted copy assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
         iterator &operator=(const iterator &) = default;
                   ^
 ../src/test/crimson/seastore/test_transaction_manager.cc:98:25: note: copy assignment operator of 'iterator' is implicitly deleted because field 'parent' is of reference type 'const transaction_manager_$
         const delta_overlay_t &parent;
                                ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/test/crimson/seastore/test_transaction_manager.cc b/src/test/crimson/seastore/test_transaction_manager.cc
index db93baaeb673f..523934ed2ed24 100644
--- a/src/test/crimson/seastore/test_transaction_manager.cc
+++ b/src/test/crimson/seastore/test_transaction_manager.cc
@@ -156,8 +156,6 @@ struct transaction_manager_test_t :
       public:
 	iterator(const iterator &) = default;
 	iterator(iterator &&) = default;
-	iterator &operator=(const iterator &) = default;
-	iterator &operator=(iterator &&) = default;
 
 	iterator &operator++() {
 	  assert(is_valid());