From: Yingxin Cheng Date: Tue, 16 Jul 2024 08:09:56 +0000 (+0800) Subject: crimson/os/seastore/record_submitter: minor cleanups X-Git-Tag: v20.0.0~1304^2~8 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=ab608c0fa2499888cbbf4ce3795258bd3d17e742;p=ceph.git crimson/os/seastore/record_submitter: minor cleanups Signed-off-by: Yingxin Cheng --- diff --git a/src/crimson/os/seastore/journal/record_submitter.cc b/src/crimson/os/seastore/journal/record_submitter.cc index e5fa90b4b22b0..6b6118b87d7ff 100644 --- a/src/crimson/os/seastore/journal/record_submitter.cc +++ b/src/crimson/os/seastore/journal/record_submitter.cc @@ -40,11 +40,10 @@ RecordBatch::add_pending( assert(maybe_write_base.has_value()); assert(!write_base.has_value()); write_base = maybe_write_base; - } else { - assert(io_promise.has_value()); } state = state_t::PENDING; assert(write_base.has_value()); + assert(io_promise.has_value()); return io_promise->get_shared_future( ).then([dlength_offset, FNAME, &name diff --git a/src/crimson/os/seastore/journal/record_submitter.h b/src/crimson/os/seastore/journal/record_submitter.h index 4b38b29207387..b5d6fc07f3fc5 100644 --- a/src/crimson/os/seastore/journal/record_submitter.h +++ b/src/crimson/os/seastore/journal/record_submitter.h @@ -149,9 +149,6 @@ public: // Add to the batch, the future will be resolved after the batch is // written. // - // Set write_result_t::write_length to 0 if the record is not the first one - // in the batch. - // // write_base must be assigned when the state is empty using add_pending_ertr = JournalAllocator::write_ertr; using add_pending_ret = add_pending_ertr::future;