From: Kefu Chai <kchai@redhat.com>
Date: Mon, 30 Jul 2018 15:20:43 +0000 (+0800)
Subject: common/assert: mark assert helpers with [[gnu::cold]]
X-Git-Tag: v14.0.1~688^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ab6a032519aee01c05b2b01d45f0fd8be213bfdf;p=ceph.git

common/assert: mark assert helpers with [[gnu::cold]]

for better performance,
see
https://gcc.gnu.org/onlinedocs/gcc-7.3.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/common/assert.cc b/src/common/assert.cc
index 4a9625925f91..1530a6cba18d 100644
--- a/src/common/assert.cc
+++ b/src/common/assert.cc
@@ -33,8 +33,9 @@ namespace ceph {
     g_assert_context = cct;
   }
 
-  void __ceph_assert_fail(const char *assertion, const char *file, int line,
-			  const char *func)
+  [[gnu::cold]] void __ceph_assert_fail(const char *assertion,
+					const char *file, int line,
+					const char *func)
   {
     g_assert_condition = assertion;
     g_assert_file = file;
@@ -73,13 +74,15 @@ namespace ceph {
     abort();
   }
 
-  void __ceph_assert_fail(const assert_data &ctx)
+  [[gnu::cold]] void __ceph_assert_fail(const assert_data &ctx)
   {
     __ceph_assert_fail(ctx.assertion, ctx.file, ctx.line, ctx.function);
   }
 
-  void __ceph_assertf_fail(const char *assertion, const char *file, int line,
-			   const char *func, const char* msg, ...)
+  [[gnu::cold]] void __ceph_assertf_fail(const char *assertion,
+					 const char *file, int line,
+					 const char *func, const char* msg,
+					 ...)
   {
     ostringstream tss;
     tss << ceph_clock_now();
@@ -154,8 +157,9 @@ namespace ceph {
     abort();
   }
 
-  void __ceph_assert_warn(const char *assertion, const char *file,
-			  int line, const char *func)
+  [[gnu::cold]] void __ceph_assert_warn(const char *assertion,
+					const char *file,
+					int line, const char *func)
   {
     char buf[8096];
     snprintf(buf, sizeof(buf),