From: Sage Weil <sage@redhat.com>
Date: Fri, 16 Nov 2018 17:03:37 +0000 (-0600)
Subject: mon: by default, do NOT warn about misplaced objects
X-Git-Tag: v14.1.0~874^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ab9b8e04fe1c0557769f1d8f697a0bfcbdf7c8ce;p=ceph.git

mon: by default, do NOT warn about misplaced objects

Misplaced objects are not something that puts the health or safety of
data in jeopardy.  Don't warn about it by default.

Since this is a change in behavior, add a release note.

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/PendingReleaseNotes b/PendingReleaseNotes
index a40f4a998d8c..16f0e860fc67 100644
--- a/PendingReleaseNotes
+++ b/PendingReleaseNotes
@@ -138,6 +138,10 @@
   option, you will need to adjust your config to set the new global option
   or revert to the default of .05 (5%).
 
+* By default, Ceph no longer issues a health warning when there are
+  misplaced objects (objects that are fully replicated but not stored
+  on the intended OSDs).  You can reenable the old warning by setting
+  ``mon_warn_on_misplaced`` to ``true``.
 
 Upgrading from Luminous
 -----------------------
diff --git a/src/common/options.cc b/src/common/options.cc
index 31c5a57600c6..421127af4038 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -1524,7 +1524,7 @@ std::vector<Option> get_global_options() {
     .set_description("Enable POOL_APP_NOT_ENABLED health check"),
 
     Option("mon_warn_on_misplaced", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
-    .set_default(true)
+    .set_default(false)
     .set_description("Issue a health warning if there are misplaced objects"),
 
     Option("mon_max_snap_prune_per_epoch", Option::TYPE_UINT, Option::LEVEL_ADVANCED)