From: Radoslaw Zarzynski <rzarzyns@redhat.com>
Date: Mon, 22 Jun 2020 15:37:53 +0000 (+0200)
Subject: crimson, common: validate the BlueStore's config for AlienStore.
X-Git-Tag: v16.1.0~1969^2~1
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ac7e867e442871e898bbaa0436defe58f281a247;p=ceph.git

crimson, common: validate the BlueStore's config for AlienStore.

This commit bases on the idea from Kefu Chai. Thanks!

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
---

diff --git a/src/common/options.cc b/src/common/options.cc
index 660c2688e73a..8414d1708b27 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -4430,6 +4430,20 @@ std::vector<Option> get_global_options() {
 
     Option("bluestore_rocksdb_cf", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
     .set_default(true)
+#ifdef WITH_SEASTAR
+    // This is necessary as the Seastar's allocator imposes restrictions
+    // on the number of threads that entered malloc/free/*. Unfortunately,
+    // RocksDB sharding in BlueStore dramatically lifted the number of
+    // threads spawn during RocksDB's init.
+    .set_validator([](std::string *value, std::string *error_message){
+      if (*value != "false") {
+        *error_message = "invalid BlueStore sharding configuration."
+                         " Be aware any change takes effect only on mkfs!";
+        return -EINVAL;
+      }
+      return 0;
+    })
+#endif
     .set_description("Enable use of rocksdb column families for bluestore metadata"),
 
     Option("bluestore_rocksdb_cfs", Option::TYPE_STR, Option::LEVEL_DEV)