From: Jason Dillaman <dillaman@redhat.com>
Date: Thu, 7 Apr 2016 20:38:33 +0000 (-0400)
Subject: test: avoid leaking librados connections when creating pools
X-Git-Tag: v10.1.2~30^2~1
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=acfc2b182a63e3600e6b72a0ebe85435b8f70b4a;p=ceph-ci.git

test: avoid leaking librados connections when creating pools

Fixes: http://tracker.ceph.com/issues/15354
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
---

diff --git a/src/test/rbd_mirror/test_ClusterWatcher.cc b/src/test/rbd_mirror/test_ClusterWatcher.cc
index 1629a16f132..2d7d3f2717f 100644
--- a/src/test/rbd_mirror/test_ClusterWatcher.cc
+++ b/src/test/rbd_mirror/test_ClusterWatcher.cc
@@ -45,7 +45,8 @@ public:
   void create_pool(bool enable_mirroring, const peer_t &peer,
                    string *uuid = nullptr, string *name=nullptr) {
     string pool_name = get_temp_pool_name("test-rbd-mirror-");
-    ASSERT_EQ("", create_one_pool_pp(pool_name, *m_cluster));
+    ASSERT_EQ(0, m_cluster->pool_create(pool_name.c_str()));
+
     int64_t pool_id = m_cluster->pool_lookup(pool_name.c_str());
     ASSERT_GE(pool_id, 0);
     m_pools.insert(pool_name);
@@ -84,7 +85,8 @@ public:
   void create_cache_pool(const string &base_pool, string *cache_pool_name) {
     bufferlist inbl;
     *cache_pool_name = get_temp_pool_name("test-rbd-mirror-");
-    ASSERT_EQ("", create_one_pool_pp(*cache_pool_name, *m_cluster));
+    ASSERT_EQ(0, m_cluster->pool_create(cache_pool_name->c_str()));
+
     ASSERT_EQ(0, m_cluster->mon_command(
       "{\"prefix\": \"osd tier add\", \"pool\": \"" + base_pool +
       "\", \"tierpool\": \"" + *cache_pool_name +
diff --git a/src/test/rbd_mirror/test_ImageReplayer.cc b/src/test/rbd_mirror/test_ImageReplayer.cc
index 18f1441682a..10310f1d70c 100644
--- a/src/test/rbd_mirror/test_ImageReplayer.cc
+++ b/src/test/rbd_mirror/test_ImageReplayer.cc
@@ -76,14 +76,14 @@ public:
     EXPECT_EQ("", connect_cluster_pp(m_local_cluster));
 
     m_local_pool_name = get_temp_pool_name();
-    EXPECT_EQ("", create_one_pool_pp(m_local_pool_name, m_local_cluster));
+    EXPECT_EQ(0, m_local_cluster.pool_create(m_local_pool_name.c_str()));
     EXPECT_EQ(0, m_local_cluster.ioctx_create(m_local_pool_name.c_str(),
 					      m_local_ioctx));
 
     EXPECT_EQ("", connect_cluster_pp(m_remote_cluster));
 
     m_remote_pool_name = get_temp_pool_name();
-    EXPECT_EQ("", create_one_pool_pp(m_remote_pool_name, m_remote_cluster));
+    EXPECT_EQ(0, m_remote_cluster.pool_create(m_remote_pool_name.c_str()));
     m_remote_pool_id = m_remote_cluster.pool_lookup(m_remote_pool_name.c_str());
     EXPECT_GE(m_remote_pool_id, 0);
 
diff --git a/src/test/rbd_mirror/test_PoolWatcher.cc b/src/test/rbd_mirror/test_PoolWatcher.cc
index b8ff3117b30..5d131d37c27 100644
--- a/src/test/rbd_mirror/test_PoolWatcher.cc
+++ b/src/test/rbd_mirror/test_PoolWatcher.cc
@@ -54,7 +54,8 @@ TestPoolWatcher() : m_lock("TestPoolWatcherLock"),
 
   void create_pool(bool enable_mirroring, const peer_t &peer, string *name=nullptr) {
     string pool_name = get_temp_pool_name("test-rbd-mirror-");
-    ASSERT_EQ("", create_one_pool_pp(pool_name, *m_cluster));
+    ASSERT_EQ(0, m_cluster->pool_create(pool_name.c_str()));
+
     int64_t pool_id = m_cluster->pool_lookup(pool_name.c_str());
     ASSERT_GE(pool_id, 0);
     m_pools.insert(pool_name);
@@ -83,7 +84,8 @@ TestPoolWatcher() : m_lock("TestPoolWatcherLock"),
   void create_cache_pool(const string &base_pool, string *cache_pool_name) {
     bufferlist inbl;
     *cache_pool_name = get_temp_pool_name("test-rbd-mirror-");
-    ASSERT_EQ("", create_one_pool_pp(*cache_pool_name, *m_cluster));
+    ASSERT_EQ(0, m_cluster->pool_create(cache_pool_name->c_str()));
+
     ASSERT_EQ(0, m_cluster->mon_command(
       "{\"prefix\": \"osd tier add\", \"pool\": \"" + base_pool +
       "\", \"tierpool\": \"" + *cache_pool_name +
diff --git a/src/test/rbd_mirror/test_fixture.cc b/src/test/rbd_mirror/test_fixture.cc
index 56620db0cd0..34981eac95f 100644
--- a/src/test/rbd_mirror/test_fixture.cc
+++ b/src/test/rbd_mirror/test_fixture.cc
@@ -22,11 +22,13 @@ TestFixture::TestFixture() {
 }
 
 void TestFixture::SetUpTestCase() {
+  ASSERT_EQ("", connect_cluster_pp(_rados));
+
   _local_pool_name = get_temp_pool_name("test-rbd-mirror-");
-  ASSERT_EQ("", create_one_pool_pp(_local_pool_name, _rados));
+  ASSERT_EQ(0, _rados.pool_create(_local_pool_name.c_str()));
 
   _remote_pool_name = get_temp_pool_name("test-rbd-mirror-");
-  ASSERT_EQ("", create_one_pool_pp(_remote_pool_name, _rados));
+  ASSERT_EQ(0, _rados.pool_create(_remote_pool_name.c_str()));
 }
 
 void TestFixture::TearDownTestCase() {