From: John Spray <john.spray@redhat.com>
Date: Fri, 22 Aug 2014 16:22:07 +0000 (+0100)
Subject: osdc/Objecter: avoid locking two sessions at once
X-Git-Tag: v0.86~213^2~6
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=ad193e1e2d8c8218334c02fde9a4589ac810aced;p=ceph.git

osdc/Objecter: avoid locking two sessions at once

... in close_session

Signed-off-by: John Spray <john.spray@redhat.com>
---

diff --git a/src/osdc/Objecter.cc b/src/osdc/Objecter.cc
index bfb786761955d..27a203649c40d 100644
--- a/src/osdc/Objecter.cc
+++ b/src/osdc/Objecter.cc
@@ -1279,6 +1279,8 @@ void Objecter::_reopen_session(OSDSession *s)
 
 void Objecter::close_session(OSDSession *s)
 {
+  assert(rwlock.is_wlocked());
+
   ldout(cct, 10) << "close_session for osd." << s->osd << dendl;
   if (s->con) {
     s->con->mark_down();
@@ -1286,34 +1288,29 @@ void Objecter::close_session(OSDSession *s)
   }
   s->lock.get_write();
 
+  std::list<LingerOp*> homeless_lingers;
+  std::list<CommandOp*> homeless_commands;
+  std::list<Op*> homeless_ops;
+
   while(!s->linger_ops.empty()) {
     std::map<uint64_t, LingerOp*>::iterator i = s->linger_ops.begin();
     ldout(cct, 10) << " linger_op " << i->first << dendl;
     _session_linger_op_remove(s, i->second);
-    {
-      RWLock::WLocker wl(homeless_session->lock);
-      _session_linger_op_assign(homeless_session, i->second);
-    }
+    homeless_lingers.push_back(i->second);
   }
 
   while(!s->ops.empty()) {
     std::map<ceph_tid_t, Op*>::iterator i = s->ops.begin();
     ldout(cct, 10) << " op " << i->first << dendl;
     _session_op_remove(s, i->second);
-    {
-      RWLock::WLocker wl(homeless_session->lock);
-      _session_op_assign(homeless_session, i->second);
-    }
+    homeless_ops.push_back(i->second);
   }
 
   while(!s->command_ops.empty()) {
     std::map<ceph_tid_t, CommandOp*>::iterator i = s->command_ops.begin();
     ldout(cct, 10) << " command_op " << i->first << dendl;
     _session_command_op_remove(s, i->second);
-    {
-      RWLock::WLocker wl(homeless_session->lock);
-      _session_command_op_assign(homeless_session, i->second);
-    }
+    homeless_commands.push_back(i->second);
   }
 
   osd_sessions.erase(s->osd);
@@ -1321,6 +1318,23 @@ void Objecter::close_session(OSDSession *s)
   assert(s->get_nref() == 1);  // We reassigned any/all ops, so should be last ref
   put_session(s);
 
+  // Assign any leftover ops to the homeless session
+  {
+    RWLock::WLocker wl(homeless_session->lock);
+    for (std::list<LingerOp*>::iterator i = homeless_lingers.begin();
+         i != homeless_lingers.end(); ++i) {
+      _session_linger_op_assign(homeless_session, *i);
+    }
+    for (std::list<Op*>::iterator i = homeless_ops.begin();
+         i != homeless_ops.end(); ++i) {
+      _session_op_assign(homeless_session, *i);
+    }
+    for (std::list<CommandOp*>::iterator i = homeless_commands.begin();
+         i != homeless_commands.end(); ++i) {
+      _session_command_op_assign(homeless_session, *i);
+    }
+  }
+
   logger->set(l_osdc_osd_sessions, osd_sessions.size());
 }