From: Samuel Just <sjust@redhat.com>
Date: Wed, 29 Sep 2021 03:26:21 +0000 (-0700)
Subject: crimson/os/seastore/segment_manager/block: add debugging to remaining invarg case
X-Git-Tag: v17.1.0~780^2~2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=ada436ff233c685f1096dfe13af701001d3143cf;p=ceph-ci.git

crimson/os/seastore/segment_manager/block: add debugging to remaining invarg case

Signed-off-by: Samuel Just <sjust@redhat.com>
---

diff --git a/src/crimson/os/seastore/segment_manager/block.cc b/src/crimson/os/seastore/segment_manager/block.cc
index 72e51973f3c..b1970838644 100644
--- a/src/crimson/os/seastore/segment_manager/block.cc
+++ b/src/crimson/os/seastore/segment_manager/block.cc
@@ -324,8 +324,14 @@ Segment::close_ertr::future<> BlockSegment::close()
 Segment::write_ertr::future<> BlockSegment::write(
   segment_off_t offset, ceph::bufferlist bl)
 {
-  if (offset < write_pointer || offset % manager.superblock.block_size != 0)
+  if (offset < write_pointer || offset % manager.superblock.block_size != 0) {
+    logger().error(
+      "BlockSegmentManager::BlockSegment::write: "
+      "invalid segment write on segment {} to offset {}",
+      id,
+      offset);
     return crimson::ct_error::invarg::make();
+  }
 
   if (offset + bl.length() > manager.superblock.segment_size)
     return crimson::ct_error::enospc::make();