From: Andrew Chang <andrewrchang@meta.com>
Date: Mon, 16 Dec 2024 19:17:27 +0000 (-0800)
Subject: Explicitly mark destructors with override (#13212)
X-Git-Tag: v9.10.0^0
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=ae8fb3e5000e46d8d4c9dbf3a36019c0aaceebff;p=rocksdb.git

Explicitly mark destructors with override (#13212)

Summary:
I saw these compiler warnings while preparing for the 9.10 release:

```cpp
'~CompactOnDeletionCollectorFactory' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]

'~CompactForTieringCollectorFactory' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
```

This code is from a while ago so I assume that this CI check has been failing for quite some time. We should still clean this up to avoid confusion in the future.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/13212

Test Plan: Existing CI checks should pass, and we should not see this CI check failure the next time we try to make a release/patch.

Reviewed By: jaykorean

Differential Revision: D67287794

Pulled By: archang19

fbshipit-source-id: a11230a919c0b7ef21a7219bf05f567d3d44b2d1
---

diff --git a/include/rocksdb/utilities/table_properties_collectors.h b/include/rocksdb/utilities/table_properties_collectors.h
index d0ce766ca..0f79f725e 100644
--- a/include/rocksdb/utilities/table_properties_collectors.h
+++ b/include/rocksdb/utilities/table_properties_collectors.h
@@ -33,7 +33,7 @@ class CompactOnDeletionCollectorFactory
                                     size_t deletion_trigger,
                                     double deletion_ratio);
 
-  ~CompactOnDeletionCollectorFactory() {}
+  ~CompactOnDeletionCollectorFactory() override {}
 
   TablePropertiesCollector* CreateTablePropertiesCollector(
       TablePropertiesCollectorFactory::Context context) override;
@@ -108,7 +108,7 @@ class CompactForTieringCollectorFactory
   // for what entry is eligible.
   CompactForTieringCollectorFactory(double compaction_trigger_ratio);
 
-  ~CompactForTieringCollectorFactory() {}
+  ~CompactForTieringCollectorFactory() override {}
 
   TablePropertiesCollector* CreateTablePropertiesCollector(
       TablePropertiesCollectorFactory::Context context) override;